[Swan-dev] new delta time type

D. Hugh Redelmeier hugh at mimosa.com
Sun Jan 25 23:22:40 EET 2015


| From: D. Hugh Redelmeier <hugh at mimosa.com>

| It would be good if there were a new type to represent these values.
| Currently unsigned long is used (mostly).

I think that the type of marg in complete_v1_state_transition is such
an error:

	time_t marg = deltamillisecs(
		c->sa_rekey_margin);

Also delay_cap variables in timer.c:

programs/pluto/timer.c:108:  unsigned int delay_cap = deltamillisecs(c->r_timeout); /* ms */
programs/pluto/timer.c:238:  unsigned int delay_cap = deltamillisecs(c->r_timeout);

These are more confusing than consequential.  There are probably more.


More information about the Swan-dev mailing list