[Swan-dev] nss headers

Paul Wouters paul at nohats.ca
Thu Jan 1 08:19:15 EET 2015


You are both right unfortunately :)

Happy new year!

Sent from my iPhone

> On Dec 31, 2014, at 19:52, Antony Antony <antony at phenome.org> wrote:
> 
>> On Wed, Dec 31, 2014 at 06:08:28PM -0500, D. Hugh Redelmeier wrote:
>> 
>> | commit 91d81c4bc76c6997b72e5ffb2fa82e36ea043b92
>> | Author: Antony Antony <antony at phenome.org>
>> | Date:   Wed Dec 31 20:47:17 2014 +0100
>> | 
>> |     ikev2: nss3/key.h => key.h
>> 
>> -#include "nss3/key.h" /* for SECKEY_DestroyPublicKey */
>> +#include "key.h" /* for SECKEY_DestroyPublicKey */
>> 
>> This header has an unreasonably generic name.  I think that the
>> include was MUCH clear before this change.
> 
> It was not clear for gcc on Debian:) Default deb install it else where.
> That is why I changed. If we need something else 
> 
>> There are several other cases where the nss3 headers have unreasonably
>> generic names.  For example, base64.h, certdb, cert.h, jar*.h.
>> Perhaps all includes of nss headers should explicitly contain nss3/
>> 
>> Bonus: we should be able to eliminate a -I flag.
> 
> -I is set using pkg-config; here are two variants I came across and imagine there are more.
> 
> Debian
> pkg-config --cflags nss
> -I/usr/include/nss -I/usr/include/nspr 
> 
> on Fedora 20.
> pkg-config --cflags nss
> -I/usr/include/nss3 -I/usr/include/nspr4 
> 
> happy 2015,
> -antony
> _______________________________________________
> Swan-dev mailing list
> Swan-dev at lists.libreswan.org
> https://lists.libreswan.org/mailman/listinfo/swan-dev


More information about the Swan-dev mailing list