[Swan-dev] nss headers

Antony Antony antony at phenome.org
Thu Jan 1 02:52:18 EET 2015


On Wed, Dec 31, 2014 at 06:08:28PM -0500, D. Hugh Redelmeier wrote:
> 
> | commit 91d81c4bc76c6997b72e5ffb2fa82e36ea043b92
> | Author: Antony Antony <antony at phenome.org>
> | Date:   Wed Dec 31 20:47:17 2014 +0100
> | 
> |     ikev2: nss3/key.h => key.h
> 
> -#include "nss3/key.h" /* for SECKEY_DestroyPublicKey */
> +#include "key.h" /* for SECKEY_DestroyPublicKey */
> 
> This header has an unreasonably generic name.  I think that the
> include was MUCH clear before this change.

It was not clear for gcc on Debian:) Default deb install it else where.
That is why I changed. If we need something else 

> There are several other cases where the nss3 headers have unreasonably
> generic names.  For example, base64.h, certdb, cert.h, jar*.h.
> Perhaps all includes of nss headers should explicitly contain nss3/
> 
> Bonus: we should be able to eliminate a -I flag.

-I is set using pkg-config; here are two variants I came across and imagine there are more.

Debian
pkg-config --cflags nss
-I/usr/include/nss -I/usr/include/nspr 

on Fedora 20.
pkg-config --cflags nss
-I/usr/include/nss3 -I/usr/include/nspr4 

happy 2015,
-antony


More information about the Swan-dev mailing list