[Swan-dev] Generate test certificates iff missing

[Andrew Cagney]

On 21 December 2015 at 12:38, Paul Wouters <paul at nohats.ca> wrote:
> On Wed, 9 Dec 2015, Antony Antony wrote:
>
>> this has more side effects.
>> how do I disable expired certs check in Makefile.inc.local?
>> If not I thinking disable this check in the master.
>>
>> the side effect  is
>> when I use 'make check "UPDATEONLY=1"' and the rule think the cert
>> 'expired' it abort UPDATEONLY.
>> That is not desired behavior.

Perhaps try "make -j 5 kvm-install".

Regardless, I checked this in.

diff --git a/testing/pluto/Makefile b/testing/pluto/Makefile
index 59c700d..8ca0108 100644
--- a/testing/pluto/Makefile
+++ b/testing/pluto/Makefile
@@ -26,7 +26,9 @@ include $(top_srcdir)/mk/config.mk
 UTILS=${LIBRESWANSRCDIR}/testing/utils

 check:         ${LIBRESWANSRCDIR}/kvmsetup.sh
+ifeq ($(UPDATEONLY),)
        $(MAKE) -C $(LIBRESWANSRCDIR) kvm-keys-up-to-date
+endif
 # skip rebuilding KVMs unless started with: make check UPDATE=1
 ifneq ($(UPDATE)$(UPDATEONLY),)
        ${LIBRESWANSRCDIR}/testing/utils/runkvm.py --reboot --compile
--install --hostname east

>> make check "UPDATEONLY=1" is used while working one specific test case
>> that has nothing to do with certs and want update the pluto on vm.
>> Especially the uncommited working directory.
>
>
> Can you not run: make kvm-clean-keys kvm-keys check UPDATEONLY=1
>
> Keys really need to be up to date to get passing OCSP and CRL tests.
>
> Note that nic needs to have the ocspd package installed too. I noticed
> your blackswan does not have it and is failing various tests because of
> it.
>
> Paul
>
> _______________________________________________
> Swan-dev mailing list
> Swan-dev at lists.libreswan.org
> https://lists.libreswan.org/mailman/listinfo/swan-dev