[Swan-dev] Andrew's fixes for bugs I introduced

Andrew Cagney andrew.cagney at gmail.com
Wed Aug 5 15:52:22 EEST 2015


On 30 July 2015 at 16:44, Andrew Cagney <andrew.cagney at gmail.com> wrote:
>
>> I ran a test run to see what I had caused to break.  I missed these.
>> Perhaps because I only looked at tests that had passed and then
>> failed.  Another example of why it is important to get more of our
>> test baseline files up to date.
>
> both sanitize.sh and re-sanitize.sh use "diff -N -u -w -b -B ..."
> which will suppresses many white space changes.

Just FYI, I hacked kvmresults.py to check if a test result difference
was just whitespace.  It didn't find any.  While there are whitespace
differences, they are mixed in with real changes.

Anyway, I suspect the above diff line could do with a tweak.
Completely ignoring spaces in a comparison seems pretty dangerous.


More information about the Swan-dev mailing list