[Swan-dev] Pluto mysteries that need solving

[Antony Antony]

Hi Hugh, 
it is good that you got rid of dnshostname checks. That makes is easier to read. 

I was looking how an instantiated connection get updated/removed from host pair list and trying figure out mysteries update_host_pairs. Specially when dpd/liveness action is restart.

When restart_connections_by_peer is dealing with a connection instance.
it will try to delete an instance and start again. When restarting , it should kick the template one.

If I go down from there I see strange things in delete connection logic. There recursive calls 
with changed c->kind? update_host_pairs .. looks strange.

Is it an accident that this commit ended up in #master? Or you are sure it is suitable for 
the upcoming bug fix release?  

-antony

On Wed, Oct 29, 2014 at 03:25:15AM -0400, D. Hugh Redelmeier wrote:
> My latest commit highlights some mysteries.
> 
> I would like some other eyes on them.
> 
> In particular, I think that some of what I poked at is under Antony's 
> microscope at the moment.
> 
> (I hope that this will hit the public git tree within a week.)
> 
> | From: D. Hugh Redelmeier <hugh at vault.libreswan.fi>
> | To: swan-commit at lists.libreswan.org
> | Date: Wed, 29 Oct 2014 09:18:30 +0200
> | Subject: [Swan-commit] Changes to ref refs/heads/master
> | Reply-To: swan-dev at lists.libreswan.org
> | 
> | New commits:
> | commit 695af25112cdd1561e71b75cf6f054b76c66907a
> | Author: D. Hugh Redelmeier <hugh at mimosa.com>
> | Date:   Wed Oct 29 03:12:06 2014 -0400
> | 
> |     pluto: clean up things associated with struct connection's dnsname field
> |     
> |     - whack.c's decoding was awkward.  Borrow logic from confread.c
> |       Still not ideal: the diagostics for bad syntax are not humane
> |       in either place.
> |     
> |     - connection.c's update_host_pairs has some mysteries.
> |     
> |     - initiate.c's ISAKMP_SA_established looks wrong (asymmetry)
> _______________________________________________
> Swan-dev mailing list
> Swan-dev at lists.libreswan.org
> https://lists.libreswan.org/mailman/listinfo/swan-dev
>