[Swan-dev] oddly redundant flags Pluto accepts

[D. Hugh Redelmeier]

[I'm top posting!  I've included this old thread because it is relevent, 
but not TOO important to read.]

I've made some changes to option handling (for now only on my private
branch, but I hope that changes).

I declared all but one spelling of an option obsolete (they still work).
Synonyms obsoleted:

  noklips, use-none, useklips, use-auto, usenetkey, coredir,
  ipsec_dir, foodgroupsdir, debug-nat_t, debug-nat-t, debug-crypto,
  debug-klips, debug-netkey,

This is easy to change if there is pressure to do so, thanks to the
newly enhanced option table mechanism.

I would like to get these changes in before the next release so that
transitioning starts sooner rather than later.

Of course few people actually use pluto options.  And we've killed off
many of those users (the embeded guys) by requiring NSS.

I have not changed the documentation at this point but it must be
done.

| From: D. Hugh Redelmeier <hugh at mimosa.com>
| Date: Wed, 19 Feb 2014 01:05:34 -0500 (EST)

| Pluto still takes --foodgroupsdir.  Why?
| 
| It is a synonym for --ipsecdir and --ipsec_dir.
| 
| Only --ipsecdir is documented.  So that's the only one that should
| remain.
| 
| 
| It also looks as if these are all synonyms:
| 	{ "noklips", no_argument, NULL, 'n' },
| 	{ "use-nostack",  no_argument, NULL, 'n' },
| 	{ "use-none",     no_argument, NULL, 'n' },
| Does that make any sense?
| 
| 
| And these:
| 	{ "useklips",  no_argument, NULL, 'k' },
| 	{ "use-klips",  no_argument, NULL, 'k' },
| One spelling, please!
| 
| 	{ "debug-nat_t", no_argument, NULL, '5' },
| 	{ "debug-nattraversal", no_argument, NULL, '5' },
| 	{ "debug-nat-t", no_argument, NULL, '5' },
| 
| 
| 	{ "use-mast",   no_argument, NULL, 'M' },
| 	{ "use-mastklips", no_argument, NULL, 'M' },
| 
| 
| 	{ "usenetkey", no_argument, NULL, 'K' },
| 	{ "use-netkey", no_argument, NULL, 'K' },
| 
| For all of the above, I'd say pick one.  The documented one.  And get
| rid of the others.
| 
| 	{ "coredir", required_argument, NULL, 'C' },
| 	{ "dumpdir", required_argument, NULL, 'C' }, /* alias for coredir */
| Only coredir is documented.
| But it is called dumpdir in the configfile, I think.
| It would make sense to pick one and make both use the same one.
| Since almost nobody uses the pluto flags (as far as I know), we should
| use "dumpdir".  In fact, Pluto's diagnostic concerning this directory
| calls it dumpdir.

| From: Paul Wouters <paul at nohats.ca>
| Date: Wed, 19 Feb 2014 10:34:18 -0500 (EST)
| Subject: Re: [Swan-dev] oddly redundant flags Pluto accepts

| On Wed, 19 Feb 2014, D. Hugh Redelmeier wrote:
| 
| > Pluto still takes --foodgroupsdir.  Why?
| >
| > It is a synonym for --ipsecdir and --ipsec_dir.
| 
| Because it is a different concept, and might not be the same dir in the
| future? The old OE code was left in until the new OE code is ready, so
| this will most likely get cleaned up in the next few months.
| 
| > It also looks as if these are all synonyms:
| 
| I'm not sure of the entire history for these, but in general we only
| document the one you should use, and have some undocumented ones for
| backwards compatibility. Likely, these got renamed in the past. So yes,
| at some point they can go. Probably the fork would have been a good
| time, so I think we can remove these redundant ones.
| 
| >  { "coredir", required_argument, NULL, 'C' },
| >  { "dumpdir", required_argument, NULL, 'C' }, /* alias for coredir */
| > Only coredir is documented.
| > But it is called dumpdir in the configfile, I think.
| > It would make sense to pick one and make both use the same one.
| > Since almost nobody uses the pluto flags (as far as I know), we should
| > use "dumpdir".  In fact, Pluto's diagnostic concerning this directory
| > calls it dumpdir.
| 
| But coredir is more obvious. People on embedded systems often start
| pluto outside the scripts, using pluto options.
| 
| Paul
| 

| From: Tuomo Soini <tis at foobar.fi>
| Date: Wed, 19 Feb 2014 22:08:43 +0200

| I'd still drop option coredir when we have dumpdir which is only real
| one being used.