[Swan-dev] junk DNA

D. Hugh Redelmeier hugh at mimosa.com
Sat May 10 08:18:55 EEST 2014


timetoa is defined two places, identically, and that's silly.  I'm 
deleting the one in programs/pluto/lswtime.c.  Unfortunately, I've put 
another function in there so I cannot delete that file until I find
another home for it.

As far as I can tell, none of our code uses anything in 
  lib/libbsdpfkey/pfkey_dump.c
I'd like to delete it, but for now I will just wrap the whole thing in
#if 0.

include/libbsdkame/libpfkey.h declares a bunch of things.  It seems to 
have been copied from FreeBSD (and they copied it from KAME).  The first 
line says:
/* I do not understand why this is not installed into /usr/include on FreeBSD */
(git blame attributes this to Paul Wouters   2008-05-28)

Some of the things libpfkey.h declares are defined in
  lib/libbsdpfkey/pfkey.c
but are never used.
  ipsec_check_keylen
  ipsec_check_keylen2 (only used by ipsec_check_keylen)
  ipsec_get_keylen
[I stopped checking at this point]
Can we ditch these or do they magically get used in FreeBSD or OSX?


More information about the Swan-dev mailing list