[Swan-dev] [Swan-commit] Changes to ref refs/heads/master

[Lennart Sorensen]

On Sat, Mar 29, 2014 at 09:50:19PM +0200, Tuomo Soini wrote:
> No. coding style is very strict about not to use spaces for indent. You
> are expected to match as near as you can with tabs, not match exactly
> like in your sample.

Well I looked through a number of files at random, and all I found used
tabs and spaces to line up.

I thought I had read that indentation was supposed to be only tabs,
but the examples I found didn't agree with that.

> My commits I have always tested with kernel provided checkpatch.pl
> utility to conform coding style. I guess everybody should use the
> utility for now before committing stuff in so we all learn our coding
> style. It's not easy process to switch coding style when we all know
> better than coding style which is correct style :-)
> 
> Our worst problem is too long functions - we have over 1000 lines long
> functions in the code and we should start splitting those to more
> sensible size, maximum should be like 50 lines of code for each
> function - but that's hard and time consuming work. Only way to do that
> is piece by piece so we have working code all the time and won't break
> it with too big changes at the same time.

checkpatch.pl is a great tool.

Splitting large functions would certainly be great, but yeah what a job
that can be.

-- 
Len Sorensen