[Swan-dev] suspicious code in linux/net/ipsec/ipsec_ocf.c

[D. Hugh Redelmeier]

        crp->crp_flags =
		CRYPTO_F_SKBUF |
                (ipsec_ocf_cbimm ? CRYPTO_F_BATCH : 0) |
		(ipsec_ocf_batch ? CRYPTO_F_BATCH : 0) |
		0;

First of all, "| 0;" is pointless.

Second of all, along with CRYPTO_F_BATCH, cryptodev.h defines 
CRYPTO_F_CBIMM.

So: should the code be:

        crp->crp_flags =
		CRYPTO_F_SKBUF |
                (ipsec_ocf_cbimm ? CRYPTO_F_CBIMM : 0) |
		(ipsec_ocf_batch ? CRYPTO_F_BATCH : 0);

or should it be

        crp->crp_flags =
		CRYPTO_F_SKBUF |
                (ipsec_ocf_cbimm | ipsec_ocf_batch ? CRYPTO_F_BATCH : 0);

(a simplified version of the current code.)