[Swan-dev] wicked waste of CPU

D. Hugh Redelmeier hugh at mimosa.com
Fri Mar 21 05:10:03 EET 2014


These commands server no useful purpose and waste a fair bit of time.
reply_buffer is 64k long.  One of these is executed for every output
packet.

reply_buffer contains NO secrets: it only ever contains what will go
out on the wire.

These should go.

programs/pluto/ikev2_parent.c:858:	zero(reply_buffer);
programs/pluto/ikev2_parent.c:1500:	zero(reply_buffer);
programs/pluto/ikev2_parent.c:1975:		zero(reply_buffer);
programs/pluto/ikev2_parent.c:2912:			zero(reply_buffer);
programs/pluto/ikev2_parent.c:3455:		zero(reply_buffer);
programs/pluto/ikev1_aggr.c:479:	zero(reply_buffer);
programs/pluto/ikev1_aggr.c:812:	zero(reply_buffer);
programs/pluto/ikev1_aggr.c:1225:	zero(reply_buffer);
programs/pluto/ikev1_main.c:165:	zero(reply_buffer);
programs/pluto/ikev1_main.c:792:	zero(reply_buffer);
programs/pluto/ikev1_main.c:1053:	zero(reply_buffer);
programs/pluto/ikev1_main.c:2350:	zero(reply_buffer);
programs/pluto/ikev1_main.c:2520:	zero(reply_buffer);
programs/pluto/ikev1_main.c:2743:	zero(reply_buffer);
programs/pluto/ipsec_doi.c:111:	zero(reply_buffer);


More information about the Swan-dev mailing list