[Swan-dev] commit dc19cb54108c3e3831a29c343803bf57e935838a

[Tuomo Soini]

On Mon, 17 Mar 2014 11:37:40 -0400 (EDT)
"D. Hugh Redelmeier" <hugh at mimosa.com> wrote:

> | From: Tuomo Soini <tis at vault.libreswan.fi>
> 
> | commit dc19cb54108c3e3831a29c343803bf57e935838a
> | Author: Tuomo Soini <tis at foobar.fi>
> | Date:   Mon Mar 17 13:51:32 2014 +0200
> | 
> |     ipsec: help, don't list commands twice when LIBDIR = EXECDIR
> 
> +       if [ ${IPSEC_LIBDIR} = ${IPSEC_EXECDIR} ]; then
> 
> I think that should be
> 
>        if [ "${IPSEC_LIBDIR}" = "${IPSEC_EXECDIR}" ]; then
> 

Only if we should really support path names with spaces in them.

> Also
> +           HELPDIRS=${IPSEC_EXECDIR}
> 
> should probably be
> +           HELPDIRS="${IPSEC_EXECDIR}"

Same for this...

> (Simple quoting cannot save
> +       for f in $(ls ${HELPDIRS} | egrep -v -i "${DONTMENTION}"); do
>                  ================
> It was wrong before you made changes.)

And it is still not proper - No simple trick to make path name with
spaces work - but at least help output is now easier to read.

-- 
Tuomo Soini <tis at foobar.fi>
Foobar Linux services
+358 40 5240030
Foobar Oy <http://foobar.fi/>