[Swan-dev] oddly redundant flags Pluto accepts

D. Hugh Redelmeier hugh at mimosa.com
Wed Feb 19 08:05:34 EET 2014


Pluto still takes --foodgroupsdir.  Why?

It is a synonym for --ipsecdir and --ipsec_dir.

Only --ipsecdir is documented.  So that's the only one that should
remain.


It also looks as if these are all synonyms:
	{ "noklips", no_argument, NULL, 'n' },
	{ "use-nostack",  no_argument, NULL, 'n' },
	{ "use-none",     no_argument, NULL, 'n' },
Does that make any sense?


And these:
	{ "useklips",  no_argument, NULL, 'k' },
	{ "use-klips",  no_argument, NULL, 'k' },
One spelling, please!

	{ "debug-nat_t", no_argument, NULL, '5' },
	{ "debug-nattraversal", no_argument, NULL, '5' },
	{ "debug-nat-t", no_argument, NULL, '5' },


	{ "use-mast",   no_argument, NULL, 'M' },
	{ "use-mastklips", no_argument, NULL, 'M' },


	{ "usenetkey", no_argument, NULL, 'K' },
	{ "use-netkey", no_argument, NULL, 'K' },

For all of the above, I'd say pick one.  The documented one.  And get
rid of the others.

	{ "coredir", required_argument, NULL, 'C' },
	{ "dumpdir", required_argument, NULL, 'C' }, /* alias for coredir */
Only coredir is documented.
But it is called dumpdir in the configfile, I think.
It would make sense to pick one and make both use the same one.
Since almost nobody uses the pluto flags (as far as I know), we should
use "dumpdir".  In fact, Pluto's diagnostic concerning this directory
calls it dumpdir.


More information about the Swan-dev mailing list