[Swan-dev] problem in latest git version

[D. Hugh Redelmeier]

| From: Tuomo Soini <tis at foobar.fi>

| Crashing pluto last night show me being wrong - even when oid.c and
| oid.h changes caused double free I must admit git commit
| 2b722e09987d96a3d9c75be7e5378fd6297af128 causes continuous crashes. I'd
| revert this change and reapply as small chunks, one change in the time
| so we could bisect actual problem.

I think that there was only one risky bit I did.  I uncommented some
freeing of keys.  I guess they were commented out for a real reason,
even if it is a bad one.

I've attached a patch to comment them out again (in a different way).
Could you test?

Sorry & thanks.
-------------- next part --------------
diff --git a/programs/pluto/crypt_ke.c b/programs/pluto/crypt_ke.c
index cf5724e..3e8c4e8 100644
--- a/programs/pluto/crypt_ke.c
+++ b/programs/pluto/crypt_ke.c
@@ -164,11 +164,13 @@ void calc_ke(struct pluto_crypto_req *r)
 	if (slot != NULL)
 		PK11_FreeSlot(slot);
 
+#if 0	/* ??? currently broken.  Why? */
 	if (privk != NULL)
 		SECKEY_DestroyPrivateKey(privk);
 
 	if (pubk != NULL)
 		SECKEY_DestroyPublicKey(pubk);
+#endif
 
 	freeanychunk(prime);
 	freeanychunk(base);