[Swan-dev] testing: more results, where 169.x.x.x is removed

Antony Antony antony at phenome.org
Mon Dec 29 12:26:43 EET 2014


On Mon, Dec 29, 2014 at 01:56:44AM -0500, D. Hugh Redelmeier wrote:
> | From: Antony Antony <antony at vault.libreswan.fi>
> | To: swan-commit at lists.libreswan.org
> | Date: Sun, 28 Dec 2014 15:56:12 +0200
> | 
> | New commits:
> | commit 11749924b5a37c3b0fd6284a7c98cf9caed98212
> | Author: Antony Antony <antony at phenome.org>
> | Date:   Sun Dec 28 14:54:42 2014 +0100
> | 
> |     testing: more results, where 169.x.x.x is removed
> 
> Thanks.
> 
> Should all occurrences of 169.254.x.x be removed from the reference 
> output?

IMHO all tests that pass should be updated; the failed ones I am not sure. For now I only update tests that pass for me. And no output for wip tests.

> This command
> 	egrep -n '\<169\.254\.' testing/pluto/*/*.txt
> finds over 300 remaining.

If the test pass for me, then I update. My policy is don't update output with grep .... for a failed test. If you are updating a failed test there is a chance that the update may go wrong. And also the git log of failed test's can be confusing, these automagic updates may confuse you.

egrep -l  '\<169\.254\.' testing/pluto/*/east*.txt |wc -l 
44

I think there are ~44 tests and 300 lines. Some test cases are missing from the file TESTLIST, e.g. x509-crl-05. 'make check' do not run those. So they are not updated. Some are in TESTLIST but pass only pass on some machines:) And some need different Makefile.inc.local . I hope to fix the last one soon with Docker tests.

Should we update the failed tests? 

-antony


More information about the Swan-dev mailing list