[Swan-dev] addresspool.c: fix coding style for while loops

Antony Antony antony at phenome.org
Mon Apr 21 23:48:05 EEST 2014


Tuomo,
I pushed the changes to #master which came out of DHR's review. That means style fixes are gone:) sorry it was a lot of reordering.

Are you running a script or doing it manually? If it is script I could try myself.

regards,
-antony


On Sun, Apr 13, 2014 at 01:06:20PM -0400, D. Hugh Redelmeier wrote:
> | From: Tuomo Soini <tis at vault.libreswan.fi>
> 
> | New commits:
> | commit 268c2646cf40177516d68f6ca54ce056b3f6d87b
> | Author: Tuomo Soini <tis at foobar.fi>
> | Date:   Sun Apr 13 13:21:20 2014 +0300
> | 
> |     addresspool.c: fix coding style for while loops
> 
> Please don't do that.  As I explained earlier, there are a bunch of
> outstanding patches that Antony is considering and reviewing.  This
> just makes merging harder.  The only reason I committed a change
> (reversion) here is that your formatting changes actually broke the
> code.
> 
> If you look at branch addresspool-play, you will see that these statements 
> have been "improved" (in my opinion) and will not need that spacing fix.
> _______________________________________________
> Swan-dev mailing list
> Swan-dev at lists.libreswan.org
> https://lists.libreswan.org/mailman/listinfo/swan-dev
> 


More information about the Swan-dev mailing list