[Swan-dev] virtual %4 notation mistake

D. Hugh Redelmeier hugh at mimosa.com
Sat Apr 19 08:19:01 EEST 2014


I'm looking at (tidying) programs/pluto/virtual.c

_read_subnet() accepts a notation for the AF:
	%v6 for AF_INET6 (IPv6)
	%v4 for AF_INET (IPv4)

It also reluctantly accepts %4 for AF_INET.
This code is commented:
	/* workaround for typo "%4:" instead of "%v4:" introduced in old openswan release*/
and logs a (not-too-explicit) RC_LOG_SERIOUS warning.

Can we ditch this?

BTW, shouldn't the code be able to guess the AF from the syntax, without 
needing a prefix?

======

Do we need a registry of obsolete stuff so we can find it and delete it 
when it is time?


More information about the Swan-dev mailing list