[Swan-dev] KLIPS crashes after kernel update

Paul Wouters paul at nohats.ca
Mon Nov 4 19:47:01 EET 2013


On Mon, 4 Nov 2013, Roel van Meer wrote:

> Thomas Geulig writes:
>
>> Am Montag, 4. November 2013, 13:00:54 schrieb Roel van Meer:
>>> Nice! I arrived at the same solution, but missed the fact that
>>> when calling __ip_select_ident() directly we no longer need the series
>>> of kernel version checks, so my version is a lot more complicated..
>>> 
>>> One improvement would be that we don't need the if() in the wrapper.
>>> The caller sets frag_off to 0 so it will not match anyway.
>> 
>> I've missed that frag_off is always 0.
>> 
>> So the patch is really simple.
>
> I can confirm that this patch works correctly with kernel 3.4.67 and 3.10.17 
> and that it fixes the checksum errors I saw without it.

Thanks for the patch and testing. I'll coordinate with David to get this
merged in.

Paul


More information about the Swan-dev mailing list