[Swan-commit] Changes to ref refs/heads/main

[Andrew Cagney]

New commits:
commit b7f46d4909cdd7eac26320c66f2ec673cd41a304
Author: Andrew Cagney <cagney at gnu.org>
Date:   Tue Sep 29 11:09:58 2020 -0400

    testing: make newoe-25-cat-2 more robust
    
    Hopefully this serves as a template for how to cleanup the OE tests:
    
    - speed up start up by replacing an arbitrary sleep "giving OE a
      chance to load conns" with:
    	../../pluto/bin/wait-for.sh --match 'loaded 9' -- ipsec auto --status
    	000 Total IPsec connections: loaded 9, active 0
      (oh for: ipsec whack --connectionstatus)
    
    - make OE connections deterministic by replacing "ping -c 4" with:
    	# ping-once.sh --down -I 192.1.3.209 192.1.2.23
    	down
    	# wait-for.sh --match '192.1.2.23' -- ipsec whack --trafficstatus
            006 #2: "private-or-clear#192.1.2.0/24"[1] 10.0.10.1/32=== ...192.1.2.23, inBytes=0, outBytes=0
    	# ping-once.sh --up   -I 192.1.3.209 192.1.2.23
    	up
    	# ipsec whack --trafficstatus
    
    - remove puzzling attempt to add connections road-east and road-west
    
    - show west's connection status before shutting anything down
    
    - after shutdown, check for leaks
    
    after this two problems still exist:
    
    - connection serial numbers aren't stable - suspect problem is a
      readdir(policies) returning things in random order
    
    - the check for leaks exposes leaks, oops