[Swan-commit] Changes to ref refs/heads/master

[Andrew Cagney]

New commits:
commit 495f66bd565901dde6b6d1e9ba8694a879ac476a
Author: Andrew Cagney <cagney at gnu.org>
Date:   Fri May 29 12:43:49 2020 -0400

    orient: rewrite, use and possibly create end.ikeport when specified
    
    - match iface:port using the endpint created from
      .host_addr(ip-version+address) + iface:port's protocol + port
    
    - for port use end.ikeport, or pluto_port
    
    - should orientation with existing IFACE:PORT fail and end.ikeport,
      then create a new ADDRESS:PORT (it hangs around until the underlying
      interface is deleted, oops).
    
    - drop code skipping iface:port with .ike_float (i.e., nat and
      pluto_nat_port); this should allow end.ikeport==pluto_nat_port while
      keeping sane configs - end.ikeport != pluto_port != pluto_nat_port -
      working
    
    - drop confusing never ending inner loop that swapped ends, maybe -
      only swap ends when the orientation succeeds (suspect some error
      paths were swapping ends)
    
    - use log_global() - to match current test results (arguably should be
      using log_connection()?)
    
    - include device IP addresses in error that two devices match (test
      uses two addresses on same port)