[Swan-commit] Changes to ref refs/heads/master
Andrew Cagney
cagney at vault.libreswan.fi
Wed Apr 15 17:41:15 UTC 2020
New commits:
commit ea24984127504720ec102d880ef45c7c9891de43
Author: Andrew Cagney <cagney at gnu.org>
Date: Wed Apr 15 12:45:33 2020 -0400
logging: poison CUR_FROM; i.e, pexpect uses of CUR_FROM when debugging
Based on test results, log calls no longer rely to the global CUR_FROM
and, hence, CUR_FROM is no longer needed and should be deleted.
I'm skeptical.
More than likely there are still logging calls relying on the global
CUR_FROM lurking in the code base; they're just not tested (any
libreswan_log() or loglog() call is a suspect). Deleting CUR_FROM
would leave those logging calls with no prefix.
Hence, rather than deleting CUR_FROM, this patch poisons it. If a use
of CUR_FROM is detected AND debugging is enabled (which normal
deployments shouldn't be doing) a pexpect is logged.
More information about the Swan-commit
mailing list