[Swan-commit] Changes to ref refs/heads/master
Andrew Cagney
cagney at vault.libreswan.fi
Thu Sep 12 14:47:02 UTC 2019
New commits:
commit a8559eac47ca9d0ac7c95ba8bd207817df985eb3
Author: Andrew Cagney <cagney at gnu.org>
Date: Wed Sep 11 11:29:48 2019 -0400
ikev1: simplify "responding to Main Mode from unknown peer..." log lines
Two log lines generate the message:
- "responding to Main Mode from unknown peer THAT.HOST_ADDR:THAT.HOST_PORT"
this would be logged if INSTANCE && HOST_PORT_SPECIFIC, but, based
on the tests, this doesn't happen (the only test to even set
HOST_PORT_SPECIFIC is ikev2-51-rw-nat-ikeport, and not with
INSTANCE).
- "responding to Main Mode from unknown peer THAT.HOST_ADDR on port MD.SENDER.PORT"
this does happen, but why use THAT.HOST_ADDR to print the unknown
peer when MD.SENDER has the value (I'm guessing history, I'm pretty
sure the two are identical).
The new log line looks like:
"responding to Main Mode from unknown peer MD.SENDER"
where MD.SENDER is correctly formatted using str_sanitize_endpoint().
(when !INSTANCE, the even shorter message "resonding to Main Mode" is
logged, wonder why that doesn't include "from peer MD.SENDER").
Also; always debug-log the cookie, and debug-log HOST_PORT_SPECIFIC.
More information about the Swan-commit
mailing list