[Swan-commit] Changes to ref refs/heads/master
cagney at vault.libreswan.fi
Thu May 23 18:21:25 UTC 2019
Author: Andrew Cagney <cagney at gnu.org>
Date: Thu May 23 13:15:54 2019 -0400
Message ID: don't re-find the child initiator using v2_child_sa_initiator_with_msgid()
Since the new Message ID code is assumed to have correctly found the
CHILD that initiated a CREATE_CHILD_SA exchange, there's no point in
calling v2_child_sa_initiator_with_msgid() (via process_v2_child_ix())
trying to find a "better" child.
Suspect the old code had a habit of initially finding the wrong state
(matching just .st_msgid) but then tried to patch things up by calling
v2_child_sa_initiator_with_msgid() (matching both .st_msgid and
.st_state, but even that didn't seem reliable). Follow-up
34fa9d0681f35a82cad5af33af46b3aa474b68b8 which exposed this.
The function process_v2_child_ix() is simplified and the function
v2_child_sa_initiator_with_msgid() is deleted.
Eliminate O(#STATES) lookup.
More information about the Swan-commit