[Swan-commit] Changes to ref refs/heads/master

[D. Hugh Redelmeier]

New commits:
commit a0e86de095bc0f1b9e3347a04214f1efc7fc08ac
Author: D. Hugh Redelmeier <hugh at mimosa.com>
Date:   Tue May 14 12:50:03 2019 -0400

    testing: fix reference logs to reflect added conn_log_val calls
    
    Those were added in a08a47c41ef315dcf55746cc7f4c74ca0fb62fb1.

commit a08a47c41ef315dcf55746cc7f4c74ca0fb62fb1
Author: D. Hugh Redelmeier <hugh at mimosa.com>
Date:   Tue May 14 12:33:49 2019 -0400

    refurbish libipsecconf
    
    - clarify just what KSF_*, KBF_*, KSCF_* etc are (indices for particular arrays)
    
    - massive bug fix: reclassify many KBF_* as KNCF_*
      (KBF are config bools (or numbers); VNCF_* are conn numbers (or bools))
    
    - Clarified bizarre "loose_enum" index handling.  Made more rigorous.
    
    - Clarified left/right index handling.  Made more rigorous.
    
    - reordered ipsec_conf_keywords[] to bring left/right entries together
    
    - added checks to catch some misuse of K* indices; fixed those uncovered
    
    - in confread.c, some struct starter_config array elements are
      mirrored in discrete fields.  I made this systematic, eliminating
      some leaks and other bugs of omission.  This should make the code
      easier to maintain.
    
    - recast for-loops iterating over arrays to use the actual array size.
      This seems to have elminated a bug symptom, but I'm not sure how.
    
    - eliminated some pointless #includes and externs
    
    - starter_whack_basic_add_conn(): added conn_log_val calls for esp and ike
    
    - many incidental small improvements