[Swan-commit] Changes to ref refs/heads/master

Andrew Cagney cagney at vault.libreswan.fi
Fri Jun 14 16:33:38 UTC 2019


New commits:
commit 00f4ca6a5c4b4a8bfcfad1d6f7431409193374ab
Author: Andrew Cagney <cagney at gnu.org>
Date:   Thu Jun 13 20:30:49 2019 -0400

    ikev2: when adding a connection, use the proposal parser to generate default proposals
    
    Instead of leaving the proposals NULL and then, in the middle end,
    using defaults from static structures.
    
    As a consequence:
    
    - when updating the IKEv2 default proposals, only the proposal parser
      needs to be modified
    
    - the code in ikev2_spdb_struct.c dealing with NULL proposals is dead
    
    - eliminates an obscure bug in the code generating duplcate MSDN
      proposals from the static structures (it missed one proposal, the
      code is no longer used, and the non-static code path works)
    
    Because the IKEv2 proposal parser can exactly describe the default
    proposal suite there is no externally visible change (well, other
    than fixing that obscure bug).  This isn't true of IKEv1 (but that
    doesn't mean a similar change to IKEv1 isn't a good idea).



More information about the Swan-commit mailing list