[Swan-commit] libswwan: ike_alg.c: dh_desc_check: don't segfault if a pexpect fails

Andrew Cagney andrew.cagney at gmail.com
Thu Feb 21 01:54:20 UTC 2019


On Wed, 20 Feb 2019 at 17:37, D. Hugh Redelmeier
<hugh at vault.libreswan.fi> wrote:
>
> New commits:
> commit 43a95b7ed73b0e989b97344ec79574f6e643b09f
> Author: D. Hugh Redelmeier <hugh at mimosa.com>
> Date:   Wed Feb 20 17:33:14 2019 -0500
>
>     libswwan: ike_alg.c: dh_desc_check: don't segfault if a pexpect fails

Thanks.  Yea, they could be updated to return a bool like pexpect().

>     My guess is that the pexpect should be a passert and we should abort
>     but I'm respecting the apparent intent of the pexpect.

While trying to add a new algorithm, having the first of many mistakes
passert() is a pita.


>     This silences a clang complaint.
>
> _______________________________________________
> Swan-commit mailing list
> Swan-commit at lists.libreswan.org
> https://lists.libreswan.org/mailman/listinfo/swan-commit


More information about the Swan-commit mailing list