[Swan-commit] Changes to ref refs/heads/master

Andrew Cagney cagney at vault.libreswan.fi
Fri Feb 8 03:20:17 UTC 2019

New commits:
commit 44c002ae6c632b0776a05f51dbee2d820b3b87e8
Merge: a5ba0ac a690fd1
Author: Andrew Cagney <cagney at gnu.org>
Date:   Thu Feb 7 22:18:21 2019 -0500

    v2 msgids: simplify routing a response to the exchange initiator
    Merge commit 'a690fd1bb72fae39ca5626f4c5c84b94239dd322'

commit a690fd1bb72fae39ca5626f4c5c84b94239dd322
Author: Andrew Cagney <cagney at gnu.org>
Date:   Wed Feb 6 22:03:57 2019 -0500

    v2 msgids: use only CURRENT_REQUEST to search for exchange initiator
    Assume a failed lookup means no state waiting on the response.
    Check response Message ID against IKE SA's window.  Don't expect
    too-new, discard too old (assuming MOBIKE).

commit caa7b6ea844fe0b0529ea6a24fc120a88666402f
Author: Andrew Cagney <cagney at gnu.org>
Date:   Thu Feb 7 14:09:09 2019 -0500

    v2 msgids: invalidate current_request after the response has been processed; mostly
    Invalidate CURRENT_REQUEST after the response has been processed so
    that any duplicates are quickly discarded (the search for a state
    matching the duplicate response's Message ID will fail).
    Two things contrive to undermind this:
    - old code still finds the state, fortunately the state m/c can't find
      a transition and discards it (this triggers a pexpect() as the old
      and new code paths have diverged)
      time to switch
    - the record 'n' send code calls update_send() (setting
      CURRENT_REQUEST to the next request) before update_recv() has a
      chance to clear the old request
      this is somewhat ok as CURRENT_STATE will not match duplicates of
      this message

More information about the Swan-commit mailing list