[Swan-commit] Changes to ref refs/heads/master

Andrew Cagney cagney at vault.libreswan.fi
Thu Feb 7 15:37:54 UTC 2019

New commits:
commit 98c23f46081c9b8085b82b980c1f8cd6f4c5e2da
Author: Andrew Cagney <cagney at gnu.org>
Date:   Thu Feb 7 10:31:03 2019 -0500

    connections: inline unshare_connection() call in add_connection()
    Too confusing.
    unshare_connection() is for:
     * unshare_connection: after a struct connection has been copied,
     * duplicate anything it references so that unshareable resources
     * are no longer shared.  Typically strings, but some other things too.
    but add_connection() is trying to use it to:
     * Connection values are set using strings in the whack
     * message, unshare_connection() is responsible
     * for cloning the strings before the whack message is
     * destroyed.
    As an aside clone_thing(connection)+unshare_connection() should also
    be eliminated - blindly copying pointers is a sure fired way to
    create use-after-free bugs - but that's SEP.

More information about the Swan-commit mailing list