[Swan-commit] Changes to ref refs/heads/master

[Andrew Cagney]

New commits:
commit 6fa2fd9f21407581397d6cd6e7b24ebe6566378f
Merge: 4bc3929 87c192e
Author: Andrew Cagney <cagney at gnu.org>
Date:   Mon Feb 4 10:22:47 2019 -0500

    v2 msgids: implement simple MSGID strategy, shadow existing code
    
    Merge commit '87c192e5229d3fca3c7161f6c9dea0e7a09d4bf0'

commit 87c192e5229d3fca3c7161f6c9dea0e7a09d4bf0
Author: Andrew Cagney <cagney at gnu.org>
Date:   Wed Jan 30 22:58:20 2019 -0500

    v2 msgids: add a new Message ID / window implementation, shadow existing code
    
    The new code determines which IDs need updating using only the state
    transition's .send field and any incoming message.  It shadows the old
    code and, when debugging is enabled, pexpect()s discrepancies.
    
    Of course there be dragons.
    
    Here it come in the form of record 'n' send.  During a state
    transition, instead of adding the message to the outgoing queue and
    then letting success_v2...() send the next message in the queue, code
    is jumping the queue by recording 'n' sending messages mid-transition
    (bonus code also then deletes the state and message ...).
    
    The new code gets around this by forcing a call to
    v2_msgid_update_sent().  The old code does:
    
        v2 msgids: hack process_encrypted_informational_ikev2() to patch up .st_msgid_lastack when a response
        v2 msgids: hack delete request so that the the current Message ID is saved in the IKE SA's .st_msgid
        v2 msgids: hack v2_msgid_update_counters() to not set .st_msgid_lastrecv=v2_INVALID_MSGID when MD is fake