[Swan-commit] Changes to ref refs/heads/master

D. Hugh Redelmeier hugh at vault.libreswan.fi
Mon Aug 13 06:30:04 UTC 2018


New commits:
commit b54b6ce821c6ae09efe76ab53e490bf25512b865
Author: D. Hugh Redelmeier <hugh at mimosa.com>
Date:   Mon Aug 13 02:15:43 2018 -0400

    pluto: fix leaks in ikev2_calculate_rsa_hash; simplify ikev2_calculate_sighash
    
    - Eliminate a switch to find the precise size required of "signed_octets".
      Instead use an upper bound (known at compile time)
    
    - Use stack allocation for temporary "signed_octets".  This is easy since its
      size is bounded by a compile-time constant.  Avoids the dangers of leaking.
      (Many returns had not freed "signed_octets".)
    
    - Delay local declarations to reduce scope.
      Combine declaration with initialization where possible.
    
    - Move common code out of switch.
      Eliminate a second switch on the same value

commit b69fe446d76349754343dcb4401ad8d0f5535315
Author: D. Hugh Redelmeier <hugh at mimosa.com>
Date:   Mon Aug 13 01:39:48 2018 -0400

    pluto: tweak some formatting

commit d358f313050cc19bfa262d113866a5771bf20181
Author: D. Hugh Redelmeier <hugh at mimosa.com>
Date:   Mon Aug 13 01:31:11 2018 -0400

    pluto: ikev2_calculate_sighash result changed from stf_status to bool
    
    This reads a little better.  The only information was and is success/failure.



More information about the Swan-commit mailing list