[Swan-commit] Changes to ref refs/heads/master

Paul Wouters paul at vault.libreswan.fi
Wed Sep 27 17:38:02 UTC 2017


New commits:
commit edaf943f35f81ea7c4b89666a3edffc426678812
Author: Paul Wouters <pwouters at redhat.com>
Date:   Wed Sep 27 13:37:29 2017 -0400

    updated changes

commit 7fce36172949f48d568088c05bcf5ff517a4f451
Author: Stepan Broz <stepan.broz at gmail.com>
Date:   Wed Sep 27 13:35:14 2017 -0400

    pluto: Use XAUTH_MAX_PASS_LENGTH, not a hardcoded 64
    
    The IKEv1 XAUTH password length is limited to 64 bytes in
    programs/pluto/ikev1_auth.c:2106 by
    
    if (st->st_xauth_password.ptr == NULL) {
            char xauth_password[64];
    
    This is a mistake and the constant XAUTH_MAX_PASS_LENGTH (128) shall be
    used similarily as MAX_USERNAME_LEN is used for the username.
    
    Therefore I propose a patch to use
    
    if (st->st_xauth_password.ptr == NULL) {
            char xauth_password[XAUTH_MAX_PASS_LENGTH];
    
    so that passwords are not limited to 63 characters + newline (when
    propted from stdin). It also improves code consistency.
    
    Signed-off-by: Paul Wouters <pwouters at redhat.com>



More information about the Swan-commit mailing list