[Swan-commit] Changes to ref refs/heads/master

Andrew Cagney cagney at vault.libreswan.fi
Sat Dec 9 16:34:16 UTC 2017


New commits:
commit 08bb6fe88284b1976914eb7e3f8cae9e1c2feec9
Author: Andrew Cagney <cagney at gnu.org>
Date:   Sat Dec 9 11:20:00 2017 -0500

    events: save the event handle, and then enable the event
    
    Fixes the race:
    
      - helper thread creates event
      - helper thread enables event
      - main thread runs event, tries to use event handle
      - helper thread saves event handle
    
    for instance, in the code sequence:
    
      pexpect(ne->ne_event != NULL);
      ne->ne_cb(ne->ne_arg);
      passert(ne->ne_event != NULL);
    
    the pexpect() could fail because the handle hand't been saved
    yet the passert() would pass.
    
    Root cause of d457dede06f6e22e927590d1059e303cbe02cd82's core dump.



More information about the Swan-commit mailing list