[Swan-commit] Changes to ref refs/heads/hugh-wip

Fri Nov 1 06:56:59 EET 2013

New commits:
commit ffeaeda5cdfce731918677d2d9b368eca4dc6d5f
Author: D. Hugh Redelmeier <hugh at mimosa.com>
Date:   Fri Nov 1 00:56:07 2013 -0400

    clean up enum and set printing
    - make non-re-entrancy warnings clearer
    - added re-entrant enum_showb
    - use enum_showb to fix enum_show usage bugs
    - added strip_prefix and used it to fix hacks
    - removed pointless NULL entries in name tables
    - marked NULL terminators of bitnamesof tables
    - tidy

commit 1ba6cdd52dcee32105fde939c031440e471c8cce
Merge: 51cfae7 3fd4906
Author: D. Hugh Redelmeier <hugh at mimosa.com>
Date:   Thu Oct 31 21:26:37 2013 -0400

    Merge branch 'hugh-wip' of vault.libreswan.org:/srv/src/libreswan into hugh-wip

commit 51cfae760bd5561bf0d4ee8e3a27e57f4770df6f
Author: D. Hugh Redelmeier <hugh at mimosa.com>
Date:   Thu Oct 31 02:19:37 2013 -0400

    - delete programs/pluto/ikeping.c: its exports were not used
    - C programmers should not normally define identifiers with a leading underscore
    - make more things static
    - undo some bad uncrustification
    - simplify and clarify some code

commit 07bb55cb50826511f2cea445288a284d5e0ce4ee
Author: D. Hugh Redelmeier <hugh at mimosa.com>
Date:   Wed Oct 30 16:38:11 2013 -0400

    - make more things file static
    - rationalize placement of declarations
    - delete vestigial programs/pluto/ike_alginit.c
    - eliminate a couple of GOTOs
    - eliminate race-like bug in programs/pluto/ike_alg_status.c

commit c4710e706510cc36fc71d421c38a09dbb0d0b335
Author: D. Hugh Redelmeier <hugh at mimosa.com>
Date:   Tue Oct 29 19:25:42 2013 -0400

    - make more things in secrets.c and fetch.c file static
    - delete some unused declarations
    - #if-out lsw_has_private_key because it is unused

commit a3ab0b2014b3be08ee29c328e81bae9fe99b5848
Author: D. Hugh Redelmeier <hugh at mimosa.com>
Date:   Tue Oct 29 17:05:06 2013 -0400

    - Add copyright notice to dpd.h (just a copy from dpd.c)
    - ditch unconventionally placed and unnecessary declaration of was_eroute_idle
    - make p1_dpd_outI1 file static

commit 7413b2c222780f8d9041a25ab6c82213750ad489
Author: D. Hugh Redelmeier <hugh at mimosa.com>
Date:   Tue Oct 29 15:57:22 2013 -0400

    - move declaration of adns_reapchild to dnskey.h from server.h
    - deleted from server.h declarations of functions that no longer exist

commit 3178ca5a1b4fb98ce173609638d7fe99345b6260
Author: D. Hugh Redelmeier <hugh at mimosa.com>
Date:   Tue Oct 29 15:39:14 2013 -0400

    delete unused cmp_chunk from defs.c

commit 6a275f534b93b0e9e7fd4d89222a65d794b59d52
Author: D. Hugh Redelmeier <hugh at mimosa.com>
Date:   Tue Oct 29 15:35:26 2013 -0400

    make a few more things file static in connections.c

commit 8796bc9e52b8405fe484dbf1b182dd5fda674154
Author: D. Hugh Redelmeier <hugh at mimosa.com>
Date:   Tue Oct 29 15:17:35 2013 -0400

    make eof_from_pluto file static

commit 0ecdc6766dc832bd29d0262398464af8f06f10d6
Author: D. Hugh Redelmeier <hugh at mimosa.com>
Date:   Tue Oct 29 15:14:49 2013 -0400

    make empty_ac file static

commit 36ccd7b0fce35be88bca6d75632066c6620b4d90
Author: D. Hugh Redelmeier <hugh at mimosa.com>
Date:   Tue Oct 29 11:03:08 2013 -0400

    - fix typing of for_each_state
    - fix some uncrustify damage
    - reduce scope of some local variables
    - remove some unnecessary IFs
    - factored out child-killing code in ikev2_parent.c
    - fix very bad assumption that all states on hash chain must be children of same parent
    - added comment to explain state table better in state.c
    - factored out common code in state.c for removing a state from the state table

commit 45c5083d1351fb8d1da8c0b2fc772e1b0136591e
Author: D. Hugh Redelmeier <hugh at mimosa.com>
Date:   Tue Oct 29 11:00:47 2013 -0400

    add note about v2 calling cookies IKE SA SPIs in description of ISAKMP header

commit 07c7ac8ab714c04ec7bfa0720976e5dec3657f62
Author: D. Hugh Redelmeier <hugh at mimosa.com>
Date:   Tue Oct 29 10:55:50 2013 -0400

    - make more spdb things file static
    - local code clarification
    - improve some comments
    - fix some uncrustify damage

commit 2c75abedacdeaacbb2f24633f564b52a3c18b09b
Author: Paul Wouters <pwouters at redhat.com>
Date:   Wed Oct 30 22:46:36 2013 -0400

    updated changes

commit a9ddf554d2e01c78959e61fc0c880b5818ca32c7
Author: Paul Wouters <pwouters at redhat.com>
Date:   Wed Oct 30 22:43:59 2013 -0400

    ikev2: Fix ikev1 fallback when ikev2 fails

    Confirmed by testcase ikev2-01-fallback-ikev1

commit 417ca2008167bd463a6ff8128b3488b25682d8fb
Author: Paul Wouters <pwouters at redhat.com>
Date:   Wed Oct 30 22:42:15 2013 -0400

    testing: updated ikev2 test cases

commit 4986e9d210a3ba7633f0b569599d4905831d6bb6
Author: Paul Wouters <pwouters at redhat.com>
Date:   Wed Oct 30 12:48:56 2013 -0400

    testing: various ikev2 output updated

commit aba926bbcda1c1a6e36f4e9639073f92ce960e6f
Author: Paul Wouters <pwouters at redhat.com>
Date:   Wed Oct 30 11:50:52 2013 -0400

    pluto: disentange ikev2 transform from ikev2 next payload type

commit d576593a3259c5bd8ac5d7cedb39122eb93514c0
Author: Paul Wouters <pwouters at redhat.com>
Date:   Wed Oct 30 11:47:21 2013 -0400

    ikev2_x509: disentange an ikev1 value for an ikev2 value

    We conditionally used ISAKMP_NEXT_CR (7) instead of
    ISAKMP_NEXT_v2CERTREQ (38)

    This could have caused us to fail to ask the remote for an x.509 certificate.

commit 3b98fdaa34bcb5d18be0ffed736687ebbeea1435
Author: Paul Wouters <pwouters at redhat.com>
Date:   Wed Oct 30 11:46:48 2013 -0400

    ikev2: fixup a use of ISAKMP_NEXT_NONE to ISAKMP_NEXT_v2NONE

commit a07cb292f53628608cb850058ac98b86c4e4f069
Author: Paul Wouters <pwouters at redhat.com>
Date:   Tue Oct 29 17:56:55 2013 -0400

    pluto: disentange ikev2 proposal from ikev2 next payload type

    Don't re-use IKEv1 values. Introduced ikev2_last_proposal_names
    to distinguish these from ikev1 next_payload_type